Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adopt --app as celery global option #16040

Merged
merged 2 commits into from
Aug 4, 2021
Merged

refactor: adopt --app as celery global option #16040

merged 2 commits into from
Aug 4, 2021

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Aug 3, 2021 •
edited
Loading

SUMMARY

This PR updates the documentation for Celery flower which was not captured in #15053 for ensuring that the documentation is both Celery 4.x and 5.x compliant.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

cc: @shawnzhu

@codecov
Copy link

codecov bot commented Aug 3, 2021 •
edited
Loading

Codecov Report

Merging #16040 (535e46d) into master (4cb79e5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16040      +/-   ##
==========================================
- Coverage   76.90%   76.90%   -0.01%     
==========================================
  Files         995      995              
  Lines       52842    52842              
  Branches     6709     6709              
==========================================
- Hits        40640    40637       -3     
- Misses      11976    11979       +3     
  Partials      226      226
Flag Coverage Δ
hive 81.32% <ø> (ø)
javascript 71.30% <ø> (-0.02%) ⬇️
mysql 81.58% <ø> (-0.05%) ⬇️
postgres 81.64% <ø> (ø)
presto 81.48% <ø> (ø)
python 82.16% <ø> (ø)
sqlite 81.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 73.05% <0.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb79e5...535e46d. Read the comment docs.

graceguo-supercat
graceguo-supercat approved these changes Aug 4, 2021
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 7effa44 into master Aug 4, 2021
@john-bodley john-bodley deleted the john-bodley--docs-celery-flower branch August 4, 2021 18:46
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@john-bodley
refactor: adopt --app as celery global option (apache#16040)
3153995 
* Update installation.rst

* Update async_queries_celery.mdx
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@john-bodley
refactor: adopt --app as celery global option (apache#16040)
2ce5bfa 
* Update installation.rst

* Update async_queries_celery.mdx
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

@nytai nytai nytai approved these changes

@shawnzhu shawnzhu shawnzhu approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@john-bodley @shawnzhu @nytai @graceguo-supercat @mistercrunch